Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: fix cs #512

Merged
merged 1 commit into from
Oct 23, 2024
Merged

refac: fix cs #512

merged 1 commit into from
Oct 23, 2024

Conversation

gimler
Copy link
Contributor

@gimler gimler commented Oct 23, 2024 •
edited
Loading

fix coding style

@gimler gimler changed the title refac: filter use attribute instate of node refac: fix cs Oct 23, 2024
bocharsky-bw
bocharsky-bw approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I see some tests also fail but it seems unrelated to this PR. Do you want to give it a try to fix tests too?

@bocharsky-bw bocharsky-bw merged commit c5ab0bc into php-translation:master Oct 23, 2024
4 of 8 checks passed
@gimler gimler deleted the feature/fix-deprecations branch October 23, 2024 11:46
@gimler
Copy link
Contributor Author

gimler commented Oct 23, 2024 •
edited
Loading

@bocharsky-bw
grafik

Initially i would fix the deprecations. Can we drop support twig 2.x? Then i would open another pr and try to fix the build

@bocharsky-bw
Copy link
Member

If v2 is EOL, I'm fine to drop it then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimler @bocharsky-bw