Make further OpenSSL 1.0.2 clean up #18133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Mar 23, 2025
| case EVP_CIPH_GCM_MODE: | ||
| case EVP_CIPH_CCM_MODE: | ||
| /* We check for EVP_CIPH_OCB_MODE, because LibreSSL does not support it. */ | ||
| # ifdef EVP_CIPH_OCB_MODE |
There was a problem hiding this comment.
Minor nit:
Suggested change
| # ifdef EVP_CIPH_OCB_MODE | |
| #ifdef EVP_CIPH_OCB_MODE |
As it was indented due to the prior #if, simiarly for # ifdef NID_chacha20_poly1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was still quite a bit of code left after the previous 1.0.2 clean up. This should be hopefully all needed to get rid 1.0.2- left overs.