Skip to content

fix ClassEntry typehints #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

fix ClassEntry typehints #206

merged 4 commits into from
Apr 17, 2025

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Apr 17, 2025

  • for Argument, name and class_type were using literal values rather than the expected value
  • for ReturnType, class_type was using the literal value rather than the expected value
    Fix and add tests

brettmc added 4 commits April 17, 2025 15:07
@brettmc
fix ClassEntry typehints
b21b9b6 
- for Arguments, name and class_type were using literal values rather than the expected value
- for ReturType, class_type was using the literal value rather than the expected value
Fix and add tests
@brettmc
fmt
2664ba8
@brettmc
use non-default-value macro
1f06ebe
@brettmc
fix 8.0-8.2
c8b9636
@brettmc brettmc marked this pull request as ready for review April 17, 2025 06:46
@brettmc brettmc requested a review from jmjoy April 17, 2025 06:46
@jmjoy jmjoy merged commit 15976ca into phper-framework:master Apr 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmjoy jmjoy jmjoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettmc @jmjoy