Introduce the TokenType enum #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Sep 10, 2023
Used to replace the Token::TYPE_* constants. The TokenType::cases() method replaces the Token::TYPE_ALL constant. Adds the Token::FLAG_NONE constant with the same value as Token::TYPE_NONE. Signed-off-by: Maurício Meneghini Fauth <[email protected]>
MauricioFauth
force-pushed
the
token-type-enum
branch
from
be8d997 to
e9edd4c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
============================================
- Coverage 97.03% 96.43% -0.61%
+ Complexity 2240 2148 -92
============================================
Files 69 65 -4
Lines 5153 5014 -139
============================================
- Hits 5000 4835 -165
- Misses 153 179 +26
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to replace the
Token::TYPE_*constants.The
TokenType::cases()method replaces theToken::TYPE_ALLconstant.Adds the
Token::FLAG_NONEconstant with the same value asToken::TYPE_NONE.