Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword parsing #590

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

kamil-tekiela
Copy link
Contributor

@kamil-tekiela kamil-tekiela commented Oct 15, 2024

I am not sure if this is the right base and I don't know what the psalm and phpstan changes are about.

This should fix phpmyadmin/phpmyadmin#19320

Signed-off-by: Kamil Tekiela <[email protected]>
Signed-off-by: Kamil Tekiela <[email protected]>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, thank you

@MauricioFauth MauricioFauth merged commit abe850f into phpmyadmin:5.10.x Oct 25, 2024
19 checks passed
@MauricioFauth MauricioFauth self-assigned this Oct 25, 2024
@MauricioFauth MauricioFauth added this to the 5.10.1 milestone Oct 25, 2024
@kamil-tekiela kamil-tekiela deleted the Fix-keyword-parsing branch October 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants