-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /tests
folder from pull
#618
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
I would love to not have the tests
directory when installing using Composer, but other distribution methods usually need the tests to be present. So we can't add it to the .gitattributes
file.
Sorry.
On the other hand, finding a way to reduce the size of the tests would be great! |
@MauricioFauth I think we can re open and accept it |
@MauricioFauth what are the use cases exactly? I don't know in which other ways this repository is being used atm. |
@remicollet Could you please comment on this? In 2017, you were against adding the |
Ref: https://tracker.debian.org/pkg/phpmyadmin-sql-parser Debian imports the source code of projects into it's own git (I can work without git) Switching to git mode looks like that: https://salsa.debian.org/phpmyadmin-team/tcpdf/-/commit/4b43e784532c7ddf5b75342969fc7e24931f269f PS: the uscan config (debian/watch) is also used to detect new upstream releases to package. I will let @remicollet explain to us how it works for them/Fedora |
In Fedora we use a git snapshot to workaround this broken sources issue I still think that using .gitattributes is a shame. It is a terrible workaround for the lack of an installer for PHP libraries. |
@MauricioFauth let's get it clean for users ? Edit: target QA |
The
/tests
folder is several MBs big. It sounds like developers don't need this folder when they depend on this package and install it through Composer, so I have excluded it in.gitattributes
.