Update PrettyPrinter.php #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be solution to phpowermove#61. This counts lines difference between stms and insert new line character for every empty line.
gossi
requested changes
Apr 27, 2019
There was a problem hiding this comment.
Logic is fine, I like the diff :)
Please use php-cs-fixer (profile is included in the repo) for formatting.
Also please add tests, that cover your problem (so future releases don't regress here). Make sure, tests cover both code profiles existent atm: https://github.com/gossi/php-code-profiles/tree/master/profiles
| */ | ||
| protected function pStmts(array $nodes, $indent = true) { | ||
| $result = ''; | ||
| $nodeBefore = NULL; |
There was a problem hiding this comment.
Suggested change
| $nodeBefore = NULL; | |
| $prevNode = null; |
| } | ||
|
|
||
| if ($indent) { | ||
| return preg_replace('~\n(?!$|' . $this->noIndentToken . ')~', "\n ", $result); |
There was a problem hiding this comment.
Use code profile for indentation character(s) here.
gossi
reviewed
Apr 27, 2019
| * | ||
| * @return string Pretty printed statements | ||
| */ | ||
| protected function pStmts(array $nodes, $indent = true) { |
There was a problem hiding this comment.
travis says:
Suggested change
| protected function pStmts(array $nodes, $indent = true) { | |
| protected function pStmts(array $nodes, bool $indent = true): string { |
gossi
reviewed
Apr 27, 2019
| $result = ''; | ||
| $nodeBefore = NULL; | ||
| foreach ($nodes as $node) { | ||
| $comments = $node->getAttribute('comments', array()); |
There was a problem hiding this comment.
go modern 😉:
Suggested change
| $comments = $node->getAttribute('comments', array()); | |
| $comments = $node->getAttribute('comments', []); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be solution to #61. This counts lines difference between stms and insert new line character for every empty line.