Merge pull request #556 from veewee/enhance-client-factory-type

Enhance client factory param
phpro · Oct 25, 2024 · 98f6257 · 98f6257
2 parents a6a828e + 583efda
commit 98f6257
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 7 deletions.
diff --git a/composer.json b/composer.json
@@ -36,7 +36,7 @@
         "phpspec/phpspec": "~7.2",
         "phpspec/prophecy-phpunit": "^2.0.1",
         "phpstan/phpstan": "^1.12.7",
-        "phpunit/phpunit": "~10.5",
+        "phpunit/phpunit": "~10.5.37",
         "squizlabs/php_codesniffer": "^3.7.1",
         "symfony/cache": "^6.4 || ^7.0"
     },

diff --git a/phpunit.xml b/phpunit.xml
@@ -1,4 +1,10 @@
-<phpunit bootstrap="./test/bootstrap.php" colors="true">
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
+    displayDetailsOnPhpunitDeprecations="true"
+    bootstrap="./test/bootstrap.php"
+    colors="true"
+>
     <testsuites>
         <testsuite name="Unit">
             <directory>./test/PhproTest/SoapClient/Unit</directory>

diff --git a/src/Phpro/SoapClient/CodeGenerator/ClientFactoryGenerator.php b/src/Phpro/SoapClient/CodeGenerator/ClientFactoryGenerator.php
@@ -77,6 +77,12 @@ public function generate(FileGenerator $file, $context): string
                             'This factory can be used as a starting point '.
                             'to create your own specialized factory. Feel free to modify.'
                         )
+                        ->setTags([
+                            [
+                                'name' => 'param',
+                                'description' => 'non-empty-string $wsdl',
+                            ],
+                        ])
                 )
         );
 

diff --git a/test/PhproTest/SoapClient/Unit/CodeGenerator/ClientFactoryGeneratorTest.php b/test/PhproTest/SoapClient/Unit/CodeGenerator/ClientFactoryGeneratorTest.php
@@ -33,6 +33,8 @@ class MyclientFactory
     /**
      * This factory can be used as a starting point to create your own specialized
      * factory. Feel free to modify.
+     *
+     * @param non-empty-string \$wsdl
      */
     public static function factory(string \$wsdl) : \App\Client\Myclient
     {

diff --git a/...oTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/ArrayBoundsCalculatorTest.php b/...oTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/ArrayBoundsCalculatorTest.php
@@ -23,7 +23,7 @@ public function it_can_enhance_types(
         self::assertSame($expected, $calculator($meta));
     }
 
-    public function provideExpectations()
+    public static function provideExpectations()
     {
         yield 'simpleType' => [
             new TypeMeta(),

diff --git a/...roTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/EnumValuesCalculatorTest.php b/...roTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/EnumValuesCalculatorTest.php
@@ -31,7 +31,7 @@ public function it_fails_on_empty_enumerations(): void
         (new EnumValuesCalculator())(new TypeMeta());
     }
 
-    public function provideExpectations()
+    public static function provideExpectations()
     {
         yield 'empty' => [
             (new TypeMeta())->withEnums(['']),

diff --git a/...hproTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/TypeNameCalculatorTest.php b/...hproTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/TypeNameCalculatorTest.php
@@ -21,7 +21,7 @@ public function it_can_calculate_type_name(XsdType $xsdType, string $expected):
 
     }
 
-    public function provideTypeNameCalculations()
+    public static function provideTypeNameCalculations()
     {
         yield 'complexType' => [
             XsdType::create('ComplexType')->withMeta(

diff --git a/...roTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/UnionTypesCalculatorTest.php b/...roTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/Calculator/UnionTypesCalculatorTest.php
@@ -31,7 +31,7 @@ public function it_fails_on_empty_enumerations(): void
         (new UnionTypesCalculator())(new TypeMeta());
     }
 
-    public function provideExpectations()
+    public static function provideExpectations()
     {
         yield 'single' => [
             (new TypeMeta())->withUnions([

diff --git a/test/PhproTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/MetaTypeEnhancerTest.php b/test/PhproTest/SoapClient/Unit/CodeGenerator/TypeEnhancer/MetaTypeEnhancerTest.php
@@ -25,7 +25,7 @@ public function it_can_enhance_types(
         self::assertSame($expectedPhp, $enhancer->asPhpType($type));
     }
 
-    public function provideExpectations()
+    public static function provideExpectations()
     {
         yield 'simpleType' => [
             new TypeMeta(),