[imp] new $entity->editorId() method for entities with editor

extensions/libraries/joomla_entity/src/Users/Traits/HasEditor.php

@@ -65,16 +65,31 @@ public function editor($reload = false)
 		return $this->editor;
 	}
 
+	/**
+	 * Retrieve the associated editor ID.
+	 *
+	 * @return  integer
+	 *
+	 * @since   __DEPLOY_VERSION__
+	 */
+	public function editorId()
+	{
+		if (!$this->has($this->columnAlias(Column::EDITOR)))
+		{
+			return 0;
+		}
+
+		return (int) $this->get($this->columnAlias(Column::EDITOR));
+	}
+
 	/**
 	 * Check if this entity has an associated editor.
 	 *
 	 * @return  boolean
 	 */
 	public function hasEditor()
 	{
-		$editorId = (int) $this->get($this->columnAlias(Column::EDITOR));
-
-		return !empty($editorId);
+		return 0 !== $this->editorId();
 	}
 
 	/**

tests/Unit/Users/Traits/HasEditorTest.php

@@ -25,6 +25,58 @@ class HasEditorTest extends \PHPUnit\Framework\TestCase
 	 */
 	const EDITOR_COLUMN = 'modified_by';
 
+	/**
+	 * @test
+	 *
+	 * @return void
+	 */
+	public function editorIdReturnsZeroForMissingEditorColumn()
+	{
+		$class = $this->getMockBuilder(EntityWithAuthorAndEditor::class)
+			->disableOriginalConstructor()
+			->setMethods(array('columnAlias'))
+			->getMock();
+
+		$class->method('columnAlias')
+			->willReturn(static::EDITOR_COLUMN);
+
+		$this->assertSame(0, $class->editorId());
+	}
+
+	/**
+	 * @test
+	 *
+	 * @return void
+	 */
+	public function editorIdReturnsCorrectId()
+	{
+		$entity = $this->getMockBuilder(EntityWithAuthorAndEditor::class)
+			->disableOriginalConstructor()
+			->setMethods(array('columnAlias'))
+			->getMock();
+
+		$entity->method('columnAlias')
+			->willReturn(static::EDITOR_COLUMN);
+
+		$entity->bind(
+			[
+				'id' => 99,
+				static::EDITOR_COLUMN => 34
+			]
+		);
+
+		$this->assertSame(34, $entity->editorId());
+
+		$entity->bind(
+			[
+				'id' => 99,
+				static::EDITOR_COLUMN => 333
+			]
+		);
+
+		$this->assertSame(333, $entity->editorId());
+	}
+
 	/**
 	 * editor calls loadEditor.
 	 *
@@ -106,8 +158,7 @@ public function testHasEditorReturnsCorrectValue()
 			->setMethods(array('columnAlias'))
 			->getMock();
 
-		$class->expects($this->once())
-			->method('columnAlias')
+		$class->method('columnAlias')
 			->willReturn(static::EDITOR_COLUMN);
 
 		$reflection = new \ReflectionClass($class);