Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

CS/CI updates, Makefile switch #25

Merged
merged 9 commits into from
Apr 12, 2018

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Apr 12, 2018

  • CI/CS changed to use Makefile, no need to remember any commands - just type make and everything is done for you.
  • Deprecating PHP_CodeSniffer in favor of superior PHP-CS-Fixer; the latter won't scold poor coding practice, but instead fix all CS violations for you. You can code as you like, forget about cleaning imports, etc.
  • Added a license header to all files, required by the license.
  • Added two static analyzers in a recommendation mode, and mutation testing tool - it will automatically tell if tests isn't good enough. These are not causing a build failure yet.

Please let me know if this change is to your liking. I tried to keep code change to minimum to simplify review, more drastic changes will be coming next for a closer inspection.

@sanmai sanmai force-pushed the cs-tools-updated branch 2 times, most recently from 53f9d78 to ca30703 Compare April 12, 2018 03:54
@sanmai sanmai force-pushed the cs-tools-updated branch 7 times, most recently from fda2afc to 0161ebc Compare April 12, 2018 05:03
Only unittests and coding standards are enforced.
@sanmai sanmai force-pushed the cs-tools-updated branch from 0161ebc to 50813cc Compare April 12, 2018 05:04
@sanmai sanmai force-pushed the cs-tools-updated branch from f94fe0e to 0796c5f Compare April 12, 2018 05:20
@henrique-borba
Copy link
Contributor

It's great @sanmai. I still have to read more about the mutations, I didn't know it and it looks very useful.

SciBoard has no description, but basically it will be a kind of IPython / Jupyter built into PHPSci. I was thinking of creating a stable version of SciBoard after the release of version 0.1 (both extension and library), the primary architecture is still crap so we're probably going to rebuild SciBoard from the beginning.

Now about the library, I have some questions:

  • I get the impression that I was somewhat abusive with the traits.
  • The library does not have a standard to perform operations, for example to transform using Transpose, the function is called directly by trait Transformable, now if you use a function of the LinearAlgebra package, it will use instantiation of objects and separate operations by types , like ProductOperations.php - This seems like something we need to standardize before we move on. It would be nice if you take a look at this.

PS: I just sent the first successful instantiation test using the static toArray method. Now that it works, I will implement it in the other functions so we finally get rid of that uuid, x, y mess.

@henrique-borba henrique-borba merged commit 6c0246b into phpsci:master Apr 12, 2018
@sanmai sanmai deleted the cs-tools-updated branch April 13, 2018 01:57
@sanmai
Copy link
Contributor Author

sanmai commented Apr 13, 2018

True, traits are not making things easier to understand, but I'm not concerned about them much because it seems like everything can become a lot leaner if there will be no need to track dimensions and UUIDs in most places. Making toArray taking an instance is a good step in that direction.

@sanmai
Copy link
Contributor Author

sanmai commented Apr 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants