-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symfony uuid type descriptor #639
base: 2.0.x
Are you sure you want to change the base?
Conversation
ea7e7fb
to
9540f53
Compare
No idea why it's failing. Try removing the dependencies from require-dev you just added. |
I think it's failing cause a test uses a class from |
Also - the descriptor has to be registered, and also - add a test that shows what problem it's solving. Descriptors are already being tested in EntityColumnRuleTest. |
That fixed most existing failures; except for deprecations on the very latest version. |
@ondrejmirtes can I add the test inside the same class? Am wondering since both Ramsey and Symfony register a 'uuid' type and the one for Ramsey is already tested/used in that class. |
Yeah, sure. |
Yeah that didn't work; the error is for the Ramsey uuid type then, not Symfony. |
References #637