Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

Sava's fix for ACARS Map with URL Rewrite #100

Closed
wants to merge 2 commits into from
Closed

Sava's fix for ACARS Map with URL Rewrite #100

wants to merge 2 commits into from

Conversation

Vansers
Copy link
Contributor

@Vansers Vansers commented Apr 10, 2013

#65

Fix ACARS Map with URL Rewrite
@Vansers
Copy link
Contributor Author

Vansers commented Apr 10, 2013

a3ed87c

@nabeelio
Copy link
Member

Has this been tested with it installed in a subfolder, and at the root of a domain (ie, domain.com/phpvms vs domain.com?)

I don't remember off the top of my head what window.url returns

@Vansers
Copy link
Contributor Author

Vansers commented Apr 10, 2013

We may missed something, I think it would fail on a sub domain. We should put the defined site url and explode the last slash.

I'll give this a test when I get home.

On 2013-04-10, at 7:04, Nabeel Shahzad [email protected] wrote:

Has this been tested with it installed in a subfolder, and at the root of a domain (ie, domain.com/phpvms vs domain.com?)

I don't remember off the top of my head what window.url returns


Reply to this email directly or view it on GitHub.

@nabeelio
Copy link
Member

No problem, I'll leave it open so it can be amended :)

The Google maps code will need to be rewritten soon, since the API in use
will be soon deprecated. I'll see if I can do that soon

@Vansers
Copy link
Contributor Author

Vansers commented Apr 11, 2013

Maybe should we wait till you get sorted out with the newest google map API? I'm just guessing there can be changes to JS files?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants