Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to apt-get upgrade and ssh restart #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbarratt
Copy link

Thanks for writing up your blog post and example playbook.

Coincidentally, before the original "first 5 minutes" post went up, I'd been looking at using ansible to secure some new VPS servers (as well as configure them/deploy apps.)

In playing with your script in vagrant I found a few minor issues which seemed worth sharing back.

@phred
Copy link
Owner

phred commented Mar 15, 2013

Glad you liked the article, Joshua! I'll take a look at this patch. Thank you for trying it out and fixing it for me. :)

Fred Alger
@_phred

On Thursday, 14 March 2013 at 12:15, Joshua Barratt wrote:

Thanks for writing up your blog post and example playbook.
Coincidentally, before the original "first 5 minutes" post went up, I'd been looking at using ansible to secure some new VPS servers (as well as configure them/deploy apps.)
In playing with your script in vagrant I found a few minor issues which seemed worth sharing back.
You can merge this Pull Request by running
git pull https://github.com/jbarratt/5minbootstrap patch-1
Or view, comment on, or merge it at:
#3
Commit Summary
Tweaks to apt-get upgrade and ssh restart

File Changes
M bootstrap.yml (https://github.com/phred/5minbootstrap/pull/3/files#diff-0) (10)

Patch Links:
https://github.com/phred/5minbootstrap/pull/3.patch
https://github.com/phred/5minbootstrap/pull/3.diff

@jbarratt
Copy link
Author

For sure!

Also meant to mention I'd been finding the newer ansible syntax where you use the actual command name much more readable. Not sure if you were using the older one intentionally or not.

As in

  • name: Update APT package cache
    apt: update_cache=yes

instead of

  • name: Update APT package cache
    action: apt update_cache=yes

@phred
Copy link
Owner

phred commented Mar 15, 2013

See what I get for staying out of the loop on Ansible developments for a few months? Glad you're here to school me, I agree that it's much more readable. :-)

Fred Alger
@_phred

On Thursday, 14 March 2013 at 20:31, Joshua Barratt wrote:

For sure!

Also meant to mention I'd been finding the newer ansible syntax where you use the actual command name much more readable. Not sure if you were using the older one intentionally or not.

As in

  • name: Update APT package cache
    apt: update_cache=yes

instead of

  • name: Update APT package cache
    action: apt update_cache=yes


Reply to this email directly or view it on GitHub (#3 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants