Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Iron Curtain work #48

Merged
merged 1 commit into from
Oct 31, 2015
Merged

Make Iron Curtain work #48

merged 1 commit into from
Oct 31, 2015

Conversation

MustaphaTR
Copy link

Fixes a part of #26.

I tried changing Cursor but didn't work not sure why.
When activated first time last frame of active anim stops there and doesn't get removed.

Do we have charged anims in OpenRA. In RA2 SWs goes to their charged anim when 1 minute left.

@phrohdoh
Copy link
Owner

I remember Iron Curtain being commented-out for some actor definitions in the past.
Please find out why and be sure we aren't introducing duplicate definitions.

@MustaphaTR
Copy link
Author

I took a look to code now but couldn't see anything commented out about IC.

@phrohdoh
Copy link
Owner

@abcdefg30: Could you test this ingame if you have time to verify valid sequences?

@abcdefg30
Copy link

Looks good to me. 👍 / ✅

A few sidenotes though:

  • The idle animation stops after using the curtain once
  • What does ngiron_f do? (I suspect that could be the active animation)

@GraionDilach
Copy link

ngiron_f is the charged sequence. https://github.com/Phrohdoh/oramod-ra2/blob/master/extra-files/art.ini#L1369

In RA2, when the SW reaches 1 minute cooldown, the building plays SuperAnimTwo once, then use SuperAnimThree as idle overlay until the SW gets fired when SuperAnimFour is played to go back into SuperAnim.

@phrohdoh
Copy link
Owner

Is that setup currently possible?
If not the idle anim should at least be fixed then this can be taken.

@GraionDilach
Copy link

Best we can do atm is to make a GrantUpgradeSequence from SuperAnimTwo and SuperAnimFour using combined sequences.

@phrohdoh
Copy link
Owner

@GraionDilach I'm pretty busy currently, would you mind opening a follow-up PR if I merge this as-is?

phrohdoh added a commit that referenced this pull request Oct 31, 2015
@phrohdoh phrohdoh merged commit 405f45d into phrohdoh:ra2#master Oct 31, 2015
@MustaphaTR MustaphaTR deleted the ra2#fix_ic branch October 31, 2015 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants