Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace System.err with SLF4J calls #56

Merged
merged 6 commits into from
Apr 21, 2020
Merged

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Aug 8, 2019

This PR replaces most of our System.err calls with calls to the SLF4J logging system. This will make it easier to add debugging information in the future, when we can use verbose flags (-v, -vv) to provide increasingly detailed debugging information (#31).

Closes #51.

@gaurav gaurav marked this pull request as ready for review April 20, 2020 20:19
@gaurav gaurav force-pushed the replace-stderr-with-log4j branch from 25bd347 to 29a5e2b Compare April 20, 2020 20:27
@gaurav gaurav changed the title Add a verbose mode for improved debugging Replace System.err with SLF4J calls Apr 20, 2020
@gaurav gaurav requested a review from hlapp April 20, 2020 20:54
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though note two inline comments for consideration.

@gaurav gaurav merged commit 2041cb6 into master Apr 21, 2020
@gaurav gaurav deleted the replace-stderr-with-log4j branch April 21, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace information and error messages written to STDERR with calls to SLF4J
2 participants