refactor: trim log messages and remove walrus operators #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change seeks to clean up a few things that were discovered during recent testing, and to do so before the next release. The use of walrus operators (i.e., `:=`) has been removed in favor of more, but simpler, code. Multiline log messages have been trimmed a bit after it was discovered that lines with >71 characters wrap in constrained environments where the WIDTH is fixed at 80 characters (e.g., GitHub Actions). This is due to the space between the log level (e.g., `WARNING`) and the message being two characters instead of the assumed one, allowing a max of 71 characters for each line of the message instead of 72 as previously assumed. There is likely a better way to programmatically account for this with something in the `textwrap` module, but these small changes will do for now.
kylewillmon
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seeks to clean up a few things that were discovered during recent testing, and to do so before the next release. The use of walrus operators (i.e.,
:=) has been removed in favor of more, but simpler, code. Multiline log messages have been trimmed a bit after it was discovered that lines with >71 characters wrap in constrained environments where the WIDTH is fixed at 80 characters (e.g., GitHub Actions). This is due to the space between the log level (e.g.,WARNING) and the message being two characters instead of the assumed one, allowing a max of 71 characters for each line of the message instead of 72 as previously assumed. There is likely a better way to programmatically account for this with something in thetextwrapmodule, but these small changes will do for now.