feat: ensure Bitbucket repo URLs use HTTPS scheme #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made after discovering that Atlassian Compass components
recognize Bitbucket repository URLs only when they are
HTTPS:
and notwhen they are
HTTP:
, even though that is how the URL is provided whenobtained by getting the
BITBUCKET_GIT_HTTP_ORIGIN
environment variablevalue.
Additionally, the
is_token_set
function was refactored to adhere tothe new
ruff
preview ruleSIM103
. The latest release ofruff
introduced the new linting rule SIM103: needless-bool,
which causes the code in question to fail when run in preview mode. This
change was made now to get ahead of the rule, for when it enforces the
implicit
else
cases by default. The change was made in a way thatseeks to maintain readability and intent. Type annotations were added to
the affected function as well.
Testing / Screenshots
What a Bitbucket pipeline looks like when run with the changes from this PR:
Updating the repo URL manually:
Re-running the pipeline: