Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: account for python-semantic-release changes #421

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

maxrake
Copy link
Contributor

@maxrake maxrake commented Apr 29, 2024

The most recent weekly dependency bump caused the
python-semantic-release package to be upgraded from v9.4.2 --> v9.6.0,
which introduced breaking changes. With the irony noted, this PR seeks
to account for the changes with the following actions:

  • Replace instances of --prerelease with --as-prerelease
    • This was the breaking change
  • Make use of the new compare_url filter
    • Remove the custom macro that did the same thing
  • Remove .macros.j2 file since it only contains a constant used once

These changes were verified with local testing, using the --noop option
and comparing the output to the expected and existing output.

The most recent weekly dependency bump caused the
`python-semantic-release` package to be upgraded from v9.4.2 --> v9.6.0,
which introduced breaking changes. With the irony noted, this PR seeks
to account for the changes with the following actions:

* Replace instances of `--prerelease` with `--as-prerelease`
  * This was the breaking change
* Make use of the new `compare_url` filter
  * Remove the custom macro that did the same thing
* Remove `.macros.j2` file since it only contains a constant used once

These changes were verified with local testing, using the `--noop`
option and comparing the output to the expected and existing output.
@maxrake maxrake self-assigned this Apr 29, 2024
@maxrake maxrake requested a review from a team as a code owner April 29, 2024 18:54
@maxrake maxrake requested a review from matt-phylum April 29, 2024 18:54
@maxrake maxrake merged commit 83d3698 into main Apr 29, 2024
13 checks passed
@maxrake maxrake deleted the psr_changes branch April 29, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants