feat: add option to exclude dependency files #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd-work
requested changes
Aug 19, 2024
kylewillmon
reviewed
Aug 19, 2024
kylewillmon
reviewed
Aug 20, 2024
cd-work
previously approved these changes
Aug 20, 2024
Phylum OSS Supply Chain Risk Analysis - SUCCESSThe Phylum risk analysis is complete and has passed the active policy. |
cd-work
previously approved these changes
Aug 21, 2024
kylewillmon
reviewed
Aug 21, 2024
cd-work
approved these changes
Aug 21, 2024
maxrake
added a commit
to phylum-dev/phylum-analyze-pr-action
that referenced
this pull request
Aug 21, 2024
This PR updates the documentation for the GitHub Action to match the examples provided in phylum-dev/phylum-ci#462.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature to specify exclusions to the dependency
files found/detected when not explicitly specified by argument. The
new option accepts gitignore-style patterns, using the
pathspecthird-party library.
Closes phylum-dev/roadmap#462
Testing
The changes in this PR are available for testing with the
maxrake/phylum-ci:exclusionsDocker image found on Docker Hub.The changes were tested explicitly for each of the following environments:
The changes were not tested in the following environments since the syntax for pipeline specification is the same (YAML) as for GitHub Actions:
Output
Specifying bad patterns results in a warning:
Related
phylum-dev/phylum-analyze-pr-action#39 was created to apply the same documentation updates for the GitHub Action. That one will not be merged until after the changes from this PR have been approved, merged, and a release created from it.