Skip to content

Commit

Permalink
Run feature tests only on purl crate
Browse files Browse the repository at this point in the history
Using `--no-default-features` on the workspace does not work as expected
because the `purl_test` and `xtask` crates depend on certain features of
the `purl` crate. So with feature unification, the `purl` crate is built
with those features **enabled**.

To resolve this and simplify the tests, this patch switches the defualt
and minimal tests to only test the `purl` crate itself. The "Full" test
is left to test the entire workspace with code coverage.

This technically leaves open the possibility that `purl_test` or `xtask`
may not successfully build with default features... But since those are
test and development crates, I'm not actually concerned.
  • Loading branch information
kylewillmon committed Oct 31, 2023
1 parent 4d17bd8 commit c16878a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ jobs:
include:
- name: Minimal
runner: test
features: --no-default-features
args: -p purl --no-default-features
- name: Default
runner: test
features: ""
args: -p purl
- name: Full
runner: tarpaulin
features: --all-features
args: --all-features
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -73,4 +73,4 @@ jobs:
rm tarpaulin.tar.gz
- name: Run tests
run: cargo ${{ matrix.runner }} ${{ matrix.features }}
run: cargo ${{ matrix.runner }} ${{ matrix.args }}

0 comments on commit c16878a

Please sign in to comment.