-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check in purl code #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really really good, this is gonna be awesome to have in our toolbox 🥳 .
Looking forward to swapping out the Java Purl library inside JG and with the JNI crate use this instead (with a simplifying shim layer since all we'll want to do is pass in a string and defensively canonicalize it)
Also it looks like the Repo settings may need to be done still? Requiring approval before merges is the big one for compliance requirements, unfortunately the template repo couldn't automate those. https://github.com/phylum-dev/repo-template/blob/75643e4a1e7a1aef1c066c6a961e2f2f3b562ae2/README.md |
I don't have access to the reference branch protection rules. |
Ah did you already turn over ownership of the repo? @eeclfrei can you help then? |
Ok, I updated settings to be in line with our other repos. Let me know if you run into any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this is awesome work @matt-phylum 👏 . Learned a lot of Rustisms from this PR alone 😅
Read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool!
@matt-phylum Some other known qualifiers we may want to incorporate too that struck me this morning:
It isn't in the purl spec but there might be an undocumented need for a possible platform qualifier for pypi too? This issue tried to call them |
Some investigation for how pypi intends retrieval here may be warranted on second thought. https://pypi.org/pypi/pandas/json Pulling out one listing
Maybe the best we can do python coordinate wise is name & version since I'm guessing the various build tools select off of their execution time context?
Admittedly purl collision is unlikely since we require checksum but it'd help intuit which of the various Either way food for thought for |
This is the initial version of the PURL library.
It could use a better name.
phylum-purl
is probably not good.purl
is available. I couldn't think of anything bird themed.The repository is private for now but the intention is that the code will become public and the library be available on crates.io.