This repository has been archived by the owner on Aug 6, 2024. It is now read-only.
Fix upload command
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #61
|
"briliant" |
hanneswernery
approved these changes
May 7, 2024
Comment on lines
+177
to
+178
| // ionCube encryption is no longer supported | ||
| ionCubeEncrypted: false, |
There was a problem hiding this comment.
Can't we just skip sending the parameter then?
There was a problem hiding this comment.
The request sent by the Shopware account app contained this in its payload. Without it I got an HTTP 400.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shopware changed their store API to require a different sequence of requests when uploading a new binary or replacing an existing binary.
Old sequence:
binaryentity.binaryreceived in 1.binary.New sequence:
binarywith version, changelog and compatible Shopware versions (only when creating a new version).binary.binaryagain.Since Shopware stopped supporting ionCube encryption (it is no longer offered when creating a release via their account UI) I also deprecate the respective command option with this PR.
Fixes #61