Change filter to regexp, add Espruino to Bangle.js device #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bangle.js is supported also by other devices. Gadget bridge is using following regexp:
https://github.com/Freeyourgadget/Gadgetbridge/blob/a0948ee1cbc2a870f91d313f8e37df5f524465f7/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/devices/banglejs/BangleJSCoordinator.java#L75
I have reworked PairSelectDevice type in order to define regexp rather than aliases. The DeviceFactory is using startsWith anyway.
I was also wondering if we should rework connect page to match Device class other way around. The Gadgetbridge shows all hardware in bluetooth scan and allows pairing only when match with some pattern. Otherwise it can be useful allowing to pair with certain type even when regular expression doesn't match. Huami devices have big overlap, so It may work partially even without changes in code.
CI is failing due to #468