Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery service payload format check #467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Feb 7, 2025

I have seen some segfaults because of invalid battery service data.
Similar checks are also in other services. For example:

qDebug() << Q_FUNC_INFO << characteristic << value.toHex();
if (characteristic == UUID_CHARACTERISTIC_MOTION_STEPS) {
if (value.length() == 4) {
m_steps = TypeConversion::toUint32(value[0], value[1], value[2], value[3]);

Test failed due to #468

@jmlich jmlich changed the title Battery service Battery service payload format check Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant