Wb data iss1 #16
Open
Wb data iss1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added solution to issue #17 currently running tests on cluster |
… prevents unpickling errors when too large chunks of data are sent between nodes.
… prevents unpickling errors when too large chunks of data are sent between nodes.
jakobkolb
requested changes
May 9, 2018
|
|
||
| # METHOD 0) hopefully even faster (incl. restructering of `tasks`) | ||
| # # # --- obtaining computed tasks (ct) | ||
| with SafeHDFStore(self.path_raw) as store: |
There was a problem hiding this comment.
This needs more comprehensive inline doc to be comprehensible..
pymofa/experiment_handling.py
Outdated
| rt = rt[rt["__computed"] == False] | ||
| tasks = rt.drop("__computed", axis=1) | ||
|
|
||
| # method 1: task dataframe |
There was a problem hiding this comment.
This needs a cleanup before merging to master
pymofa/experiment_handling.py
Outdated
|
|
||
| # store results | ||
| # completed runs send thier (task, result) as return | ||
| self._obtain_store_function(n_return[0])(n_return[1]) |
There was a problem hiding this comment.
I suggest moving this to slave nodes, since sending large packages of data between nodes might lead to unpickling errors (in my experience). Will open issue and commit solution.
|
|
||
| return mix_names | ||
|
|
||
| def _obtain_store_function(self, task): |
There was a problem hiding this comment.
This function needs more inline documentation to be comprehensive..
|
Also, I approve of the deletion of the resaving function and everything related to it. |
…ction to the save function itself in _get_store_function() to prevent duplicate entries in computed tasks, that would lead to errors in the _get_computed_tasks() routine. 2) Changed the typecasting in the construction of the dataframe of all tasks in the _get_computed_tasks() routine to correct for weird typecasting in pandas' dataframe construction from dict.
…o wb_data_iss1 # Conflicts: # pymofa/experiment_handling.py
…un and supressing furter acess to database to make sure, it is closed, when the cluster finally terminates the run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change log:
To keep in mind:
resaving can be replaced by a second computation of a new handle (see tutorial 1 for example)
==> resaving functions and tutorial 3 can be removed from my side