Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Facebook Broadcasts API coverage #174

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

arsengoian
Copy link
Contributor

Hi! I just added coverage for Facebook Broadcasts API (sending messages to groups of users) and labeling, according to documentation.

Broadcast reach evaluation and some minor features were not implemented.

Tests with complete coverage for the new features are included in PR.

MAIN DOC

TARGETING BROADCASTS DOC

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage     15.78%   15.78%           
  Complexity      190      190           
=========================================
  Files            23       23           
  Lines           646      646           
=========================================
  Hits            102      102           
  Misses          544      544
Impacted Files Coverage Δ Complexity Δ
FbBotApp.php 0% <ø> (ø) 46 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67f8c56...dc6498a. Read the comment docs.

@arsengoian
Copy link
Contributor Author

Oops I didn't see the tests coming. I think tests should be moved to a different namespace, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants