Save scrolling position when switching pages or browsing the library. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed 0e6e15e which fixes an issue with the scroll position not being loaded correctly for the 'browse' pane. |
|
I intend to have a proper look at this later when I get back home. I always
envisioned we'd try and change to use scrolling divs for these
tracklist/playlists and that would mitigate some of the issues we have. The
way the scrolling currently works is really suboptimal.
…On 22 Jan 2017 8:20 a.m., "Coveralls" ***@***.***> wrote:
[image: Coverage Status] <https://coveralls.io/builds/9785586>
Coverage increased (+0.02%) to 40.872% when pulling *0e6e15e
<0e6e15e>
on jcass77:fix/73_93_scroll_positions* into *9856685
<9856685>
on pimusicbox:develop*.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#224 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5DqK2IXSufTCFfcp7anRmsi9equckPks5rUxE6gaJpZM4LqTct>
.
|
|
This PR only addresses the issues with the current scrolling mechanism. Using scrolling divs might be better as a next step (especially for the 'Playlists' page - #38). |
|
Are we happy to merge this as an interim measure until we take a closer look at #38? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73. Fixes #93.
I'm not sure whether it makes sense to add UI state (like storing the scrolling position) to the
browseStackarray. But that seems better than declaring yet another array just to persist the UI state, and then have to keep multiple structures in sync using URI identifiers?