Implementation for issue #809 and general display improvements #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Please! Can we consider this? |
|
Thanks for your PR, and sorry for not taking a look at this earlier. Personally, I'm not a fan of visual separation between different months (the first |
|
Apart from that, there seem to be some problem with the current state: 
|
|
Perhaps we can also find a way to make the separation work as a plugin first and let it mature outside of the main code base. |
|
closed for now, please re-open if you are still interested in working on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used an awful lot of try/excepts in this PR, so if you have a better way of doing it you're welcome ! Anyway this PR might not be perfect but proposes a new display for both khal and ikhal where months are visually separated. The ideas in came from @aleprovencio and @WhyNotHugo. I did it with a coworker, so i added him as well to the AUTHORS file. There might be some useless commits, just look at the final files. We won't be working on it anymore, so if it isn't receivable but you like the idea, feel free to adapt and improve it !