[ikhal] add option to disable mouse, fixes #1289 #1295
Conversation
This is done by passing the `handle_mouse` Boolean argument to urwid's main loop (currently unused). By default, the mouse remains enabled (see `khal.spec`). Mouse can be disabled either by setting `enable_mouse = False` in the `[default]` section of khal's config file, or by passing the `--no-mouse` flag to the `khal interactive` or `ikhal` click commands.
| @@ -19,3 +19,4 @@ env/ | |||
| venv/ | |||
| .hypothesis/ | |||
| .python-version | |||
| .dmypy.json | |||
There was a problem hiding this comment.
I've added this because I'm using neovim with pylsp-mypy (with the dmypy daemon, which can create this file).
There was a problem hiding this comment.
No objections on this.
Note that you can include this in ~/.config/git/ignore and git will ignore the file for all your local repositories.
There was a problem hiding this comment.
Ah thanks, did not know that. Good to know :)
khal/cli.py
Outdated
| @@ -93,6 +93,12 @@ def multi_calendar_option(f): | |||
| return d(a(f)) | |||
|
|
|||
|
|
|||
| def no_mouse_option(f): | |||
There was a problem hiding this comment.
Since I had to use this both for ikhal and khal interactive, I figured it made sense to abstract this option into its own function decorator.
khal/cli.py
Outdated
| '''Interactive UI. Also launchable via `ikhal`.''' | ||
| if no_mouse: | ||
| ctx.obj['conf']['default']['enable_mouse'] = False |
There was a problem hiding this comment.
I'm overriding the config value when the --no-mouse flag is used. Not sure this is the best way, but seems to work.
|
@WhyNotHugo i fixed the tests, can you trigger the CI build (sorry was busy with work and forgot this PR) |
Co-authored-by: Hugo <[email protected]>
|
@WhyNotHugo addressed your comments (sorry for not running the tests before), ran the tests locally and everything passes. i think you can trigger the CI again! |
|
@geier done! thanks for catching that |
|
looks like I didn't reload properly. |
|
Works, thanks! |
This is done by passing the
handle_mouseBoolean argument to urwid's main loop (currently unused). By default, the mouse remains enabled (seekhal.spec). Mouse can be disabled either by settingenable_mouse = Falsein the[default]section of khal's config file, or by passing the--no-mouseflag to thekhal interactiveorikhalclick commands.fixes #1289