Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements for the new json export #1313

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Some improvements for the new json export #1313

merged 2 commits into from
Oct 31, 2023

Conversation

geier
Copy link
Member

@geier geier commented Oct 30, 2023

suggest by @WhyNotHugo in #1308

@geier geier force-pushed the fix/json branch 2 times, most recently from 8c0023a to c78bade Compare October 30, 2023 23:31
@geier geier requested a review from WhyNotHugo October 30, 2023 23:32
d7415
d7415 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to brush up on rst syntax, but looks good to me

@geier
Copy link
Member Author

geier commented Oct 31, 2023

@d7415 you can now also check if it builds correctly on readthedocs, click the details link und the deathedocs check.

@geier geier enabled auto-merge October 31, 2023 21:46
@geier geier merged commit f1c6b1e into master Oct 31, 2023
6 checks passed
@geier geier deleted the fix/json branch October 31, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geier @WhyNotHugo @d7415