Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

New Pinecone Client #246

Merged
merged 14 commits into from
Jan 16, 2024
Merged

New Pinecone Client #246

merged 14 commits into from
Jan 16, 2024

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Jan 14, 2024

Problem

Main branch is not supporting the new Pinecone client.

Solution

Merging 0.4.0 release branch back into main.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

izellevy and others added 4 commits December 7, 2023 13:17
* Fix tests

* Change todo and erase notebooks

* Fix comments

* Fix tests

* Fix tests

* Add example

* Make unit tests independent

* Fix docs

* Fix

* Fix CI

* Update CI

* Remove connect

* Fix lint

* Remove comment

* Change readme

* Fix comments

* Fix comments

* Fix comments

---------

Co-authored-by: Izel  Levy <[email protected]>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@izellevy izellevy changed the title Add support for new Pinecone Client New Pinecone Client Jan 14, 2024
@izellevy izellevy marked this pull request as ready for review January 16, 2024 10:36
Copy link
Contributor

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a few minor comments

.github/workflows/PR.yml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/canopy/knowledge_base/knowledge_base.py Outdated Show resolved Hide resolved
src/canopy/knowledge_base/knowledge_base.py Outdated Show resolved Hide resolved
src/canopy/knowledge_base/knowledge_base.py Show resolved Hide resolved
@izellevy izellevy added this pull request to the merge queue Jan 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2024
@izellevy izellevy added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit dec8f94 Jan 16, 2024
7 checks passed
@izellevy izellevy deleted the release/0.4.0 branch January 16, 2024 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants