Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup bench: modify command from --output to --output-dir #10942

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Aug 17, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Close #10803

  • Modify the flag from --output to --output-dir. The --output flag has been modified to --output-dir in this tiup/211 PR, but the flag in the tiup/tiup-bench.md document is not updated. Since this change is before TiDB v4.0, this PR needs to cherry pick from v4.0 to v6.2. (issue: 文档中所有--output 都是 应该都是 --output-dir #10803)
  • Add the --output-type=csv in each command to generate CSV file (suggestions from JaySon-Huang)
  • Remove the enable pprof step (suggestions from JaySon-Huang)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs This PR is translated from a PR in pingcap/docs. area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. ONCALL Relates to documentation oncall. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.2 labels Aug 17, 2022
@Oreoxmt Oreoxmt requested review from qiancai and Yui-Song August 17, 2022 07:44
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 17, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2022
@Oreoxmt Oreoxmt added needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Aug 17, 2022
@Oreoxmt Oreoxmt requested a review from JaySon-Huang August 17, 2022 08:10
tiup/tiup-bench.md Outdated Show resolved Hide resolved
@@ -108,23 +108,23 @@ Flags:
{{< copyable "shell-regular" >}}

```shell
tiup bench tpcc --warehouses 4 prepare --output data
tiup bench tpcc --warehouses 4 prepare --output-dir data
Copy link
Contributor

@JaySon-Huang JaySon-Huang Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最新的 tiup bench/go-tpc 在不连 mysql 实例下,只生成数据到目录这个功能在经过一些迭代后,不能运作了。。 相关 issue pingcap/go-tpc#100

>  tiup bench tpcc --warehouses 4 prepare --output-dir data
tiup is checking updates for component bench ...
A new version of bench is available:
   The latest version:         v1.10.3
   Local installed version:    v1.10.2
   Update current component:   tiup update bench
   Update all components:      tiup update --all

Starting component `bench`: /root/.tiup/components/bench/v1.10.2/tiup-bench tpcc --warehouses 4 prepare --output-dir data
Cannot open database, please check it (ip/port/username/password)
Error: dial tcp 127.0.0.1:4000: connect: connection refused
...
dial tcp 127.0.0.1:4000: connect: connection refused

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不过假如用户执行的时候,在 127.0.0.1:4000 上有 tidb 或 mysql,那么是可以运行的。文档改动先忽略这个报错的问题好了。

tiup/tiup-bench.md Outdated Show resolved Hide resolved
tiup/tiup-bench.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from JaySon-Huang August 17, 2022 08:51
tiup/tiup-bench.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt requested a review from JaySon-Huang August 17, 2022 08:56
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10953.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10954.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10955.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10956.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10957.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10958.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10959.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10960.

@Oreoxmt Oreoxmt deleted the issue/docs-cn-10803 branch February 14, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

文档中所有--output 都是 应该都是 --output-dir
5 participants