-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tiup bench: modify command from --output to --output-dir #10942
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tiup/tiup-bench.md
Outdated
@@ -108,23 +108,23 @@ Flags: | |||
{{< copyable "shell-regular" >}} | |||
|
|||
```shell | |||
tiup bench tpcc --warehouses 4 prepare --output data | |||
tiup bench tpcc --warehouses 4 prepare --output-dir data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最新的 tiup bench
/go-tpc
在不连 mysql 实例下,只生成数据到目录这个功能在经过一些迭代后,不能运作了。。 相关 issue pingcap/go-tpc#100
> tiup bench tpcc --warehouses 4 prepare --output-dir data
tiup is checking updates for component bench ...
A new version of bench is available:
The latest version: v1.10.3
Local installed version: v1.10.2
Update current component: tiup update bench
Update all components: tiup update --all
Starting component `bench`: /root/.tiup/components/bench/v1.10.2/tiup-bench tpcc --warehouses 4 prepare --output-dir data
Cannot open database, please check it (ip/port/username/password)
Error: dial tcp 127.0.0.1:4000: connect: connection refused
...
dial tcp 127.0.0.1:4000: connect: connection refused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不过假如用户执行的时候,在 127.0.0.1:4000 上有 tidb 或 mysql,那么是可以运行的。文档改动先忽略这个报错的问题好了。
Co-authored-by: JaySon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In response to a cherrypick label: new pull request created: #10953. |
In response to a cherrypick label: new pull request created: #10954. |
In response to a cherrypick label: new pull request created: #10955. |
In response to a cherrypick label: new pull request created: #10956. |
In response to a cherrypick label: new pull request created: #10957. |
In response to a cherrypick label: new pull request created: #10958. |
In response to a cherrypick label: new pull request created: #10959. |
In response to a cherrypick label: new pull request created: #10960. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Close #10803
--output
to--output-dir
. The--output
flag has been modified to--output-dir
in this tiup/211 PR, but the flag in thetiup/tiup-bench.md
document is not updated. Since this change is before TiDB v4.0, this PR needs to cherry pick from v4.0 to v6.2. (issue: 文档中所有--output 都是 应该都是 --output-dir #10803)--output-type=csv
in each command to generate CSV file (suggestions from JaySon-Huang)Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
tiup bench
with more tpch flags tiup#211Do your changes match any of the following descriptions?