Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add witness related docs #12628

Draft
wants to merge 106 commits into
base: master
Choose a base branch
from
Draft

Conversation

ethercflow
Copy link
Contributor

@ethercflow ethercflow commented Jan 10, 2023

ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

TiDB v6.6.0 supports witness.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • SunRunAway

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from Oreoxmt January 10, 2023 08:08
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2023
@Oreoxmt Oreoxmt self-assigned this Jan 10, 2023
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Jan 10, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Jan 10, 2023
@Oreoxmt Oreoxmt added the v6.6 label Jan 10, 2023
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update PD config as well?

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 16, 2023
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <[email protected]>
@ethercflow ethercflow requested a review from Connor1996 January 16, 2023 04:22
ref tikv/tikv#12876

Signed-off-by: Wenbo Zhang <[email protected]>
@ethercflow ethercflow requested a review from Connor1996 January 16, 2023 06:42
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jan 28, 2023

@Connor1996 @SunRunAway PTAL

@Oreoxmt Oreoxmt added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. labels Jan 29, 2023
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 7, 2023
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added v7.0 and removed v6.6 labels Feb 9, 2023
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023

CLA assistant check
All committers have signed the CLA.

@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-future-release This PR only applies to master for now and might cherry-pick to a future release. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v7.0 labels Mar 9, 2023
@Oreoxmt Oreoxmt marked this pull request as draft January 21, 2025 08:41
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Indicates that the Issue or PR belongs to the area of scheduling. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. for-future-release This PR only applies to master for now and might cherry-pick to a future release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants