Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: update debezium protocol #18894

Merged
merged 9 commits into from
Nov 26, 2024
Merged

cdc: update debezium protocol #18894

merged 9 commits into from
Nov 26, 2024

Conversation

wk989898
Copy link
Contributor

@wk989898 wk989898 commented Oct 22, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

add key field for Debezium protocol. see pingcap/tiflow#11652

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 22, 2024
@qiancai qiancai added the area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. label Oct 24, 2024
@qiancai qiancai self-assigned this Oct 24, 2024
@qiancai qiancai added the translation/doing This PR’s assignee is translating this PR. label Oct 24, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 24, 2024
Copy link
Contributor

@hongyunyan hongyunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest is LGTM

ticdc/ticdc-debezium.md Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Oct 25, 2024

@hongyunyan: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

rest is LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai added v8.5 for-release This PR relates to a TiDB release but does not have a tracked feature. labels Nov 4, 2024
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2024
@qiancai qiancai requested a review from Oreoxmt November 25, 2024 07:21
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
ticdc/ticdc-debezium.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 26, 2024
Copy link

ti-chi-bot bot commented Nov 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 02:00:24.156329098 +0000 UTC m=+839986.347198096: ☑️ agreed by qiancai.
  • 2024-11-26 07:12:58.718620636 +0000 UTC m=+534166.338275151: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented Nov 26, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 5ce3c10 into pingcap:master Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR. v8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants