Describe TiCDC support in TiFlash #20012

CalvinNeo · 2025-03-07T02:03:31Z

First-time contributors' checklist

I've signed Contributor License Agreement that's required for repo owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

What is the related PR or file link(s)?

This PR is translated from:
Other reference link(s):

Do your changes match any of the following descriptions?

Delete files
Change aliases
Need modification after applied to another branch
Might cause conflicts after applied to another branch

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

tiflash/create-tiflash-replicas.md

Co-authored-by: wlwilliamx <53336371+wlwilliamx@users.noreply.github.com>

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

JaySon-Huang

LGTM

ti-chi-bot · 2025-03-10T14:20:48Z

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JaySon-Huang · 2025-03-10T14:21:28Z

Related description supplement on TiCDC: #20022, we'd better merge them together

chenmin1992 · 2025-03-11T07:15:26Z

tiflash/create-tiflash-replicas.md

@@ -53,6 +53,10 @@ ALTER TABLE `tpch50`.`lineitem` SET TIFLASH REPLICA 0;

 * v5.1 版本及后续版本将不再支持设置系统表的 replica。在集群升级前，需要清除相关系统表的 replica，否则升级到较高版本后将无法再修改系统表的 replica 设置。

+> **注意：**
+>
+> 目前，使用 TiCDC 同步表到下游 TiDB 集群时，不支持为表创建 TiFlash 副本。


没说清楚吧，直接说“TiCDC 不会同步添加或移除 TiFlash 副本的 DDL (ALTER TABLE table_name SET TIFLASH REPLICA count;)”就好了，简单明了。

感谢，已经修改了~

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

CalvinNeo · 2025-03-11T09:23:18Z

#20022

Already merged, please check @JaySon-Huang @flowbehappy @wlwilliamx

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

JaySon-Huang

LGTM

ti-chi-bot · 2025-03-13T12:31:52Z

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ticdc/ticdc-compatibility.md

tiflash/create-tiflash-replicas.md

ti-chi-bot · 2025-03-31T11:39:29Z

[LGTM Timeline notifier]

Timeline:

2025-03-31 11:39:28.778647382 +0000 UTC m=+1478862.462883478: ☑️ agreed by hfxsd.

tiflash/create-tiflash-replicas.md

hfxsd · 2025-04-01T06:14:19Z

/approve

ti-chi-bot · 2025-04-01T06:14:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hfxsd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2025-04-01T06:18:11Z

In response to a cherrypick label: new pull request created to branch release-8.1: #20149.

ti-chi-bot · 2025-04-01T06:18:50Z

In response to a cherrypick label: new pull request created to branch release-8.5: #20150.

ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2025

fix cdc

b5e1fad

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

CalvinNeo force-pushed the fix-cdc branch from af8adcd to b5e1fad Compare March 7, 2025 02:09

CalvinNeo added 2 commits March 7, 2025 11:00

fix cdc2

f565ba3

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

fix cdc3

a39e451

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

JaySon-Huang reviewed Mar 7, 2025

View reviewed changes

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved

wlwilliamx reviewed Mar 7, 2025

View reviewed changes

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved

CalvinNeo and others added 3 commits March 7, 2025 16:26

Update tiflash/create-tiflash-replicas.md

7c8ca69

Co-authored-by: wlwilliamx <53336371+wlwilliamx@users.noreply.github.com>

f

30a4d5b

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

Merge branch 'fix-cdc' of github.com:CalvinNeo/docs-cn into fix-cdc

46b5bf5

CalvinNeo requested a review from JaySon-Huang March 7, 2025 08:35

hfxsd self-assigned this Mar 10, 2025

JaySon-Huang approved these changes Mar 10, 2025

View reviewed changes

chenmin1992 reviewed Mar 11, 2025

View reviewed changes

CalvinNeo added 2 commits March 11, 2025 17:19

fix

4dc177d

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

merge

1749c75

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025

merge

979e1a1

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>

JaySon-Huang approved these changes Mar 13, 2025

View reviewed changes

CalvinNeo requested a review from chenmin1992 March 17, 2025 08:20

CalvinNeo requested a review from wlwilliamx March 17, 2025 08:20

hfxsd reviewed Mar 31, 2025

View reviewed changes

ticdc/ticdc-compatibility.md Outdated Show resolved Hide resolved

hfxsd reviewed Mar 31, 2025

View reviewed changes

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved

hfxsd reviewed Mar 31, 2025

View reviewed changes

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved

Apply suggestions from code review

671a40f

hfxsd mentioned this pull request Mar 31, 2025

Describe TiCDC support in TiFlash pingcap/docs#20681

Merged

16 tasks

hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 31, 2025

hfxsd approved these changes Mar 31, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 31, 2025

hfxsd added the lgtm label Apr 1, 2025

hfxsd reviewed Apr 1, 2025

View reviewed changes

tiflash/create-tiflash-replicas.md Outdated Show resolved Hide resolved

Update tiflash/create-tiflash-replicas.md

5942555

ti-chi-bot bot added the approved label Apr 1, 2025

ti-chi-bot bot merged commit a2cd852 into pingcap:master Apr 1, 2025
7 checks passed

This was referenced Apr 1, 2025

Describe TiCDC support in TiFlash (#20012) #20149

Merged

Describe TiCDC support in TiFlash (#20681) pingcap/docs#20685

Merged

This was referenced Apr 1, 2025

Describe TiCDC support in TiFlash (#20012) #20150

Merged

Describe TiCDC support in TiFlash (#20681) pingcap/docs#20686

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2025

Describe TiCDC support in TiFlash (#20012) (#20150)

2804665

ti-chi-bot bot pushed a commit that referenced this pull request Apr 1, 2025

Describe TiCDC support in TiFlash (#20012) (#20149)

6261de7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Describe TiCDC support in TiFlash #20012

Describe TiCDC support in TiFlash #20012

CalvinNeo commented Mar 7, 2025 •

edited by hfxsd

Loading

JaySon-Huang left a comment

ti-chi-bot bot commented Mar 10, 2025

JaySon-Huang commented Mar 10, 2025 •

edited

Loading

chenmin1992 Mar 11, 2025

CalvinNeo Mar 11, 2025

CalvinNeo commented Mar 11, 2025

JaySon-Huang left a comment

ti-chi-bot bot commented Mar 13, 2025

ti-chi-bot bot commented Mar 31, 2025

hfxsd commented Apr 1, 2025

ti-chi-bot bot commented Apr 1, 2025

ti-chi-bot commented Apr 1, 2025

ti-chi-bot commented Apr 1, 2025

Describe TiCDC support in TiFlash #20012

Describe TiCDC support in TiFlash #20012

Conversation

CalvinNeo commented Mar 7, 2025 • edited by hfxsd Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

JaySon-Huang left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Mar 10, 2025

JaySon-Huang commented Mar 10, 2025 • edited Loading

chenmin1992 Mar 11, 2025

Choose a reason for hiding this comment

CalvinNeo Mar 11, 2025

Choose a reason for hiding this comment

CalvinNeo commented Mar 11, 2025

JaySon-Huang left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Mar 13, 2025

ti-chi-bot bot commented Mar 31, 2025

[LGTM Timeline notifier]

hfxsd commented Apr 1, 2025

ti-chi-bot bot commented Apr 1, 2025

ti-chi-bot commented Apr 1, 2025

ti-chi-bot commented Apr 1, 2025

CalvinNeo commented Mar 7, 2025 •

edited by hfxsd

Loading

JaySon-Huang commented Mar 10, 2025 •

edited

Loading