Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup-cluster-no-sudo-mode: Correct the order of operations to ensure t… #20120

Merged
merged 3 commits into from
Mar 26, 2025

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Mar 25, 2025

the right limits are applied

What is changed, added or deleted? (Required)

If the [email protected] (where 1001 is the uid of the tidb user) is started before /etc/security/limits.conf is adjusted this causes the services to not get the right NOFILE limit applied and leads to various issues.

There are three options for this:

  • Restart the service after limits.conf has been modified
  • Restart the machine after limits.conf has been modified.
  • Modify limits.conf before the service is started.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement. labels Mar 25, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025
@qiancai qiancai self-assigned this Mar 26, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 26, 2025
Copy link

ti-chi-bot bot commented Mar 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-26 07:29:22.24188161 +0000 UTC m=+1031855.926117692: ☑️ agreed by hfxsd.

@qiancai
Copy link
Collaborator Author

qiancai commented Mar 26, 2025

/approve

@qiancai qiancai added the lgtm label Mar 26, 2025
Copy link

ti-chi-bot bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 26, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4ff7596 into pingcap:master Mar 26, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20123.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants