Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the log redaction documentation #18487

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Update the log redaction documentation #18487

merged 8 commits into from
Aug 14, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Aug 6, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Aug 6, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2024
@hfxsd hfxsd requested review from JmPotato and JaySon-Huang August 6, 2024 00:34
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.3 type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. and removed missing-translation-status This PR does not have translation status info. contribution This PR is from a community contributor. labels Aug 6, 2024
JaySon-Huang
JaySon-Huang approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiflash part LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 6, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

tiflash part LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JmPotato
JmPotato reviewed Aug 6, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Aug 6, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Aug 6, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Aug 6, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Aug 6, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
LykxSassinator
LykxSassinator reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm

log-redaction.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
log-redaction.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 6, 2024

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 6, 2024

@JmPotato: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from lilin90 August 6, 2024 07:25
lilin90
lilin90 reviewed Aug 12, 2024
View reviewed changes
log-redaction.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tiflash/tiflash-configuration.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-12 06:44:16.147527021 +0000 UTC m=+163940.850996679: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 14, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Aug 14, 2024
@hfxsd hfxsd closed this Aug 14, 2024
@hfxsd hfxsd reopened this Aug 14, 2024
@hfxsd hfxsd added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 14, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 14, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 7e070f2 into pingcap:master Aug 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hfxsd @JmPotato @JaySon-Huang @LykxSassinator @lilin90