Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: make inc + log restore compatible #18557

Merged
merged 5 commits into from
Aug 15, 2024
Merged

br: make inc + log restore compatible #18557

merged 5 commits into from
Aug 15, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Aug 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Aug 12, 2024
@hfxsd hfxsd requested a review from 3pointer August 12, 2024 02:45
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2024
@hfxsd hfxsd added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. for-release This PR relates to a TiDB release but does not have a tracked feature. v8.3 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2024
@hfxsd hfxsd requested a review from BornChanger August 12, 2024 02:46
BornChanger
BornChanger reviewed Aug 12, 2024
View reviewed changes
br/br-pitr-manual.md Outdated Show resolved Hide resolved
@hfxsd @BornChanger
Update br/br-pitr-manual.md
a8f3811 
Co-authored-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd requested a review from benmeadowcroft August 12, 2024 07:30
hfxsd
hfxsd commented Aug 12, 2024
View reviewed changes
br/br-pitr-manual.md Outdated Show resolved Hide resolved
benmeadowcroft
benmeadowcroft previously requested changes Aug 12, 2024
View reviewed changes
br/br-incremental-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 12, 2024

@benmeadowcroft: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hfxsd
hfxsd commented Aug 14, 2024
View reviewed changes
br/br-incremental-guide.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from lilin90 August 14, 2024 07:40
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 14, 2024
lilin90
lilin90 reviewed Aug 15, 2024
View reviewed changes
br/br-incremental-guide.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 15, 2024
lilin90
lilin90 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-14 07:44:59.748297793 +0000 UTC m=+340384.451767435: ☑️ agreed by 3pointer.
  • 2024-08-15 06:33:53.551960385 +0000 UTC m=+422518.255430029: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 15, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2024
@hfxsd hfxsd dismissed benmeadowcroft’s stale review August 15, 2024 06:39

Suggestions are accepted.

@hfxsd
Copy link
Collaborator Author

hfxsd commented Aug 15, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 2d19dec into pingcap:master Aug 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BornChanger BornChanger BornChanger approved these changes

@lilin90 lilin90 lilin90 approved these changes

@3pointer 3pointer 3pointer approved these changes

@benmeadowcroft benmeadowcroft benmeadowcroft left review comments

Assignees

@hfxsd hfxsd

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hfxsd @benmeadowcroft @3pointer @lilin90 @BornChanger