-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace pdapi to pd sdk #5446
base: master
Are you sure you want to change the base?
replace pdapi to pd sdk #5446
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
go.mod
Outdated
@@ -221,6 +222,8 @@ require ( | |||
|
|||
replace github.com/pingcap/tidb-operator/pkg/apis => ./pkg/apis | |||
|
|||
replace github.com/tikv/pd/client => github.com/HuSharp/pd/client v0.0.0-20231207064950-c060432d1ad9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to remove this replace
and just set the version in L49?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we need to merge pd firstly
9944f8e
to
80bfb22
Compare
Signed-off-by: husharp <[email protected]>
80bfb22
to
956b754
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
related tikv/pd#7300
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.