Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: refactor test to use wait checkpoint method #57612

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

br: refactor test to use wait checkpoint method #57612

wants to merge 3 commits into from
+69 −207

Conversation

Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Nov 21, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57609

Problem Summary:

What changed and how does it work?

Extract the wait for checkpoint to advance logic in integration test to a method

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Nov 21, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leavrth for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 21, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 21, 2024

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Tristan1900
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Nov 21, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.3187%. Comparing base (49c3eba) to head (b44989e).
Report is 177 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57612        +/-   ##
================================================
+ Coverage   73.2689%   74.3187%   +1.0498%     
================================================
  Files          1650       1691        +41     
  Lines        455646     489758     +34112     
================================================
+ Hits         333847     363982     +30135     
- Misses       101279     103622      +2343     
- Partials      20520      22154      +1634
Flag Coverage Δ
integration 46.5437% <ø> (?)
unit 72.1942% <ø> (-0.3651%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (-0.1806%) ⬇️
parser ∅ <ø> (∅)
br 58.0080% <ø> (+12.0074%) ⬆️
---- 🚨 Try these New Features:

@Tristan1900
fix tests
cf56e79 
Signed-off-by: Wenqi Mou <[email protected]>
@Tristan1900
Copy link
Contributor Author

/retest

@Tristan1900
fix test
b44989e 
Signed-off-by: Wenqi Mou <[email protected]>
@tiprow tiprow
Copy link

tiprow bot commented Nov 22, 2024

@Tristan1900: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow b44989e link true /test fast_test_tiprow
tidb_parser_test b44989e link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: refactor test wait for checkpoint to advance
1 participant
@Tristan1900