br: refactor test to use wait checkpoint method

[Tristan1900]

What problem does this PR solve?

Issue Number: close #57609

Problem Summary:

What changed and how does it work?

Extract the wait for checkpoint to advance logic in integration test to a method

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @Tristan1900. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Tristan1900]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8509%. Comparing base (dcc9dcc) to head (9dd0929).
Report is 201 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57612        +/-   ##
================================================
+ Coverage   72.8037%   74.8509%   +2.0472%     
================================================
  Files          1677       1692        +15     
  Lines        464023     466534      +2511     
================================================
+ Hits         337826     349205     +11379     
+ Misses       105322      95962      -9360     
- Partials      20875      21367       +492     

Flag	Coverage Δ
integration	46.9574% <ø> (?)
unit	72.5926% <ø> (+0.3972%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <ø> (ø)
parser	∅ <ø> (∅)
br	61.2597% <ø> (+15.5711%)	⬆️

[Tristan1900]

/retest

[Tristan1900]

/retest

[BornChanger]

/retest

[BornChanger]

This is a good refactoring that follows the DRY (Don't Repeat Yourself) principle and makes the test codebase more maintainable.

[hawkingrei]

/test all

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• br/OWNERS [BornChanger,YuJuncen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-26 23:56:39.906155285 +0000 UTC m=+594387.525809795: ☑️ agreed by BornChanger.
• 2024-11-27 01:37:17.776978572 +0000 UTC m=+600425.396633088: ☑️ agreed by YuJuncen.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #58498.

[ti-chi-bot]

@Tristan1900: new pull request created to branch 6.5: #59282.

In response to this:

/cherry-pick 6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Tristan1900]

/cherry-pick release-6.5

[ti-chi-bot]

@Tristan1900: new pull request created to branch release-6.5: #59283.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[Tristan1900]

/cherry-pick release-8.1

[ti-chi-bot]

@Tristan1900: new pull request created to branch release-8.1: #59284.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.