-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add table filter for log restore #57394
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7c04493
to
8ef978b
Compare
8ef978b
to
02a2318
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Wenqi Mou <[email protected]>
02a2318
to
c29b578
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57394 +/- ##
================================================
+ Coverage 72.7907% 73.6205% +0.8298%
================================================
Files 1676 1694 +18
Lines 463750 464214 +464
================================================
+ Hits 337567 341757 +4190
+ Misses 105323 100975 -4348
- Partials 20860 21482 +622
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Wenqi Mou <[email protected]>
1764b17
to
f624281
Compare
@Tristan1900: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #57613
Problem Summary:
Need table filter for PiTR
What changed and how does it work?
The following happens if a custom filter is specified during PiTR.
TODO: maybe in this same PR. We are scanning 3 times on log backup meta, maybe we can try to reduce to 2
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.