Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: support pre-split index regions before creating index #57553

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 20, 2024

What problem does this PR solve?

Issue Number: close #57552, close #57551

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 20, 2024
Copy link

tiprow bot commented Nov 20, 2024

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta changed the title Support pre-split index regions before creating index ddl: support pre-split index regions before creating index Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 25.18519% with 303 lines in your changes missing coverage. Please review.

Project coverage is 74.6266%. Comparing base (fe1b9ed) to head (abd295c).
Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57553        +/-   ##
================================================
+ Coverage   72.8112%   74.6266%   +1.8153%     
================================================
  Files          1676       1724        +48     
  Lines        463677     474170     +10493     
================================================
+ Hits         337609     353857     +16248     
+ Misses       105228      98094      -7134     
- Partials      20840      22219      +1379     
Flag Coverage Δ
integration 49.0965% <17.0940%> (?)
unit 72.1565% <25.1851%> (-0.0556%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 60.6250% <ø> (+15.1660%) ⬆️
---- 🚨 Try these New Features:

pkg/parser/parser.y Outdated Show resolved Hide resolved
pkg/parser/ast/ddl.go Outdated Show resolved Hide resolved
pkg/parser/ast/ddl.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Show resolved Hide resolved
pkg/ddl/index.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Show resolved Hide resolved
pkg/ddl/index_presplit.go Outdated Show resolved Hide resolved
pkg/ddl/index_presplit.go Outdated Show resolved Hide resolved
pkg/ddl/index_presplit.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Nov 25, 2024

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test c96e2e3 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: D3Hunter
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta and additionally assign bb7133, bornchanger, d3hunter, yudongusa for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
Copy link

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 08:21:19.905921193 +0000 UTC m=+451867.525575708: ☑️ agreed by D3Hunter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pre-split index regions before creating index Cluster suffering write hotspot after creating index
3 participants