-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dxf: systable and scheduler change for modify task at runtime #57557
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #57557 +/- ##
================================================
+ Coverage 72.8799% 74.4630% +1.5830%
================================================
Files 1676 1692 +16
Lines 463558 467397 +3839
================================================
+ Hits 337841 348038 +10197
+ Misses 104885 97806 -7079
- Partials 20832 21553 +721
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: ref #57497
Problem Summary:
What changed and how does it work?
Add a new task state
modifying
and add a new fieldmodify_params
which holds parameters about current modification. the system table change part has verified with PM @Frank945946Add some basic interface in storage for modify and add a empty impl in scheduler
Check List
Tests
upgrade from 8.1, success, task and history table matches
bootstrap with master, success, task and history table matches
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.