Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dxf: systable and scheduler change for modify task at runtime #57557

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Nov 20, 2024

What problem does this PR solve?

Issue Number: ref #57497

Problem Summary:

What changed and how does it work?

Add a new task state modifying and add a new field modify_params which holds parameters about current modification. the system table change part has verified with PM @Frank945946
Add some basic interface in storage for modify and add a empty impl in scheduler

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

upgrade from 8.1, success, task and history table matches
bootstrap with master, success, task and history table matches

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from d3hunter and additionally assign benmeadowcroft, yujuncen for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2024
Copy link

tiprow bot commented Nov 20, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 24 lines in your changes missing coverage. Please review.

Project coverage is 74.4630%. Comparing base (31c068c) to head (662094f).
Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57557        +/-   ##
================================================
+ Coverage   72.8799%   74.4630%   +1.5830%     
================================================
  Files          1676       1692        +16     
  Lines        463558     467397      +3839     
================================================
+ Hits         337841     348038     +10197     
+ Misses       104885      97806      -7079     
- Partials      20832      21553       +721     
Flag Coverage Δ
integration 46.6539% <3.5714%> (?)
unit 72.1920% <75.2941%> (-0.0772%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (+0.1129%) ⬆️
parser ∅ <ø> (∅)
br 60.5611% <ø> (+15.2075%) ⬆️
---- 🚨 Try these New Features:

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 20, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title dxf: systable and scheduler change for modify task at runtime [WIP]dxf: systable and scheduler change for modify task at runtime Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
@D3Hunter D3Hunter changed the title [WIP]dxf: systable and scheduler change for modify task at runtime dxf: systable and scheduler change for modify task at runtime Nov 21, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 21, 2024
@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Nov 21, 2024

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant