-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: remove some NOT NULL
constraints on lightning table (#57577)
#57600
lightning: remove some NOT NULL
constraints on lightning table (#57577)
#57600
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57600 +/- ##
================================================
Coverage ? 57.1101%
================================================
Files ? 1770
Lines ? 628221
Branches ? 0
================================================
Hits ? 358778
Misses ? 245502
Partials ? 23941
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, fzzf678, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57577
What problem does this PR solve?
Issue Number: close #57578
Problem Summary:
What changed and how does it work?
#55477 change the behavior of null value insert. To adapt to this change, some
NOT NULL
constraints have to be removed.Previous PR just wrongly change
INSERT INTO
toINSERT IGNORE INTO
, which may case data correctness.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.