br: redact secret strings when logging arguments (#57593)

[ti-chi-bot]

This is an automated cherry-pick of #57593

What problem does this PR solve?

Issue Number: close #57585

Problem Summary: Some values from the command line are not properly redacted.

What changed and how does it work?

In additional to the existing handling for --storage, we also apply redaction to the following parameters:

• --full-backup-storage
• --crypter.key
• --log.crypter.key
• --azblob.encryption-key
• --master-key (the current implementation of this may be too conservative)

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

When invoking BR in command line with secret keys passed directly from arguments, they are no longer printed as plaintext in the log.

[kennytm]

/retest

spurious error in TestPBMemoryLeak.

    testkit.go:132: 
        	Error Trace:	testkit/testkit.go:132
        	            				testkit/testkit.go:125
        	            				executor/memory_test.go:44
        	Error:      	Received unexpected error:
        	            	[domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).checkSchemaValid
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1922
...
        	Test:       	TestPBMemoryLeak
        	Messages:   	sql:insert into t values (space(8192)), [], error stack [domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).checkSchemaValid
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1922
...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@ae4703a). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-6.5     #57601   +/-   ##
================================================
  Coverage               ?   73.6200%           
================================================
  Files                  ?       1097           
  Lines                  ?     352939           
  Branches               ?          0           
================================================
  Hits                   ?     259834           
  Misses                 ?      76388           
  Partials               ?      16717           

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kennytm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kennytm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-22 02:07:05.283655408 +0000 UTC m=+170212.903309923: ☑️ agreed by kennytm.