-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: redact secret strings when logging arguments (#57593) #57605
br: redact secret strings when logging arguments (#57593) #57605
Conversation
Signed-off-by: kennytm <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57605 +/- ##
================================================
Coverage ? 57.1085%
================================================
Files ? 1770
Lines ? 628228
Branches ? 0
================================================
Hits ? 358772
Misses ? 245521
Partials ? 23935
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, kennytm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #57593
What problem does this PR solve?
Issue Number: close #57585
Problem Summary: Some values from the command line are not properly redacted.
What changed and how does it work?
In additional to the existing handling for
--storage
, we also apply redaction to the following parameters:--full-backup-storage
--crypter.key
--log.crypter.key
--azblob.encryption-key
--master-key
(the current implementation of this may be too conservative)Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.