-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: reset timeout on store level (#55526) #57667
backup: reset timeout on store level (#55526) #57667
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57667 +/- ##
================================================
Coverage ? 57.0218%
================================================
Files ? 1770
Lines ? 627398
Branches ? 0
================================================
Hits ? 357754
Misses ? 245515
Partials ? 24129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/run check_dev_2 |
/run-check_dev_2 |
1 similar comment
/run-check_dev_2 |
/test check-dev2 |
@3pointer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@3pointer: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ti-chi-bot[bot]: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test check-dev2 |
@3pointer: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #55526
What problem does this PR solve?
Issue Number: close #57666
ref #53480
Problem Summary:
The previous implementation will reset on grpc level. but actually, br could have multiple grpc connections to each store. we only need a timeout on a store level. this PR tried to fix it.
What changed and how does it work?
Reset timeout when receive a backup response from a store.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.