-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare, stmtctx: fix the issue that errors/warnings in parse stage are not cleaned or reported #59276
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Yang Keao <[email protected]>
/check-issue-triage-complete |
@YangKeao: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59276 +/- ##
================================================
+ Coverage 73.0454% 73.5206% +0.4751%
================================================
Files 1689 1689
Lines 466983 467137 +154
================================================
+ Hits 341110 343442 +2332
+ Misses 104893 102731 -2162
+ Partials 20980 20964 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please check the MySQL tests.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #59275, close #59132
Problem Summary:
Parse
returns error.Parse
returns error, the error is not appended to the stmtctx for thePREPARE
binary protocol.What changed and how does it work?
Parse
returns error.PREPARE
binary protocol.Check List
Tests
Side effects
Documentation
Release note