-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: update distsql_copr_resp_size unit #59991
Conversation
Hi @zimulala. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59991 +/- ##
================================================
+ Coverage 73.0771% 75.2193% +2.1421%
================================================
Files 1702 1752 +50
Lines 470092 481807 +11715
================================================
+ Hits 343530 362412 +18882
+ Misses 105392 96952 -8440
- Partials 21170 22443 +1273
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #59990
Problem Summary:
In TiDB clusters with numerous nodes and high request loads, tidb_distsql_copr_resp_size is monitoring a large amount of data, consider reducing the number of buckets to reduce its data size.
What changed and how does it work?
Change the minimum unit from B to KiB. This can reduce the number of buckets by 50%
Check List
Tests
Before this PR:
After this PR:


Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.