Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: update distsql_copr_resp_size unit #59991

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 10, 2025

What problem does this PR solve?

Issue Number: ref #59990

Problem Summary:
In TiDB clusters with numerous nodes and high request loads, tidb_distsql_copr_resp_size is monitoring a large amount of data, consider reducing the number of buckets to reduce its data size.

What changed and how does it work?

Change the minimum unit from B to KiB. This can reduce the number of buckets by 50%

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before this PR:
1 2

After this PR:
1-1
2-1

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
Copy link

tiprow bot commented Mar 10, 2025

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.2193%. Comparing base (b72ff3b) to head (5188ebf).
Report is 22 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59991        +/-   ##
================================================
+ Coverage   73.0771%   75.2193%   +2.1421%     
================================================
  Files          1702       1752        +50     
  Lines        470092     481807     +11715     
================================================
+ Hits         343530     362412     +18882     
+ Misses       105392      96952      -8440     
- Partials      21170      22443      +1273     
Flag Coverage Δ
integration 49.0867% <100.0000%> (?)
unit 72.7328% <100.0000%> (+0.4503%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 62.3996% <ø> (+15.1769%) ⬆️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zimulala zimulala added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2025
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@zimulala zimulala removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2025
Copy link

ti-chi-bot bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 12, 2025
Copy link

ti-chi-bot bot commented Mar 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-12 06:19:15.366465074 +0000 UTC m=+336710.971994000: ☑️ agreed by lance6716.
  • 2025-03-12 06:47:00.647922557 +0000 UTC m=+338376.253451484: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 11750be into pingcap:master Mar 12, 2025
20 of 24 checks passed
@zimulala zimulala deleted the zimuxia/distsql_copr branch March 12, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants